MIDI/Instrument improvements + Misc - #1825
Merged
Merged
Conversation
Add MIDIEvent.isChannelEvent() to distinguish MIDIEvents where channels matter from ones which don't (since None is no longer an acceptable channel). Update getChannels() to use it Add midiEventToInstrument (singular event) and deprecate midiEventsToInstrument -- do it right or not at all. Remove channel on midi.translate.getEndEvents Use Python 3.11 error messages Remove deprecated MeterSequence.flat -> for .flatten() Remove deprecated musicxml/testFiles.get(contentRequest) -- never used. Add better docs to music21/prebase make roman. _postFigureFromChordAndKey private as promised. Leave figureTuples as public. remove RomanException -- just use RomanNumeralException clean up docs for v3.11
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add MIDIEvent.isChannelEvent() to distinguish MIDIEvents where channels matter from ones which don't (since None is no longer an acceptable channel). Update getChannels() to use it
Add midiEventToInstrument (singular event) and deprecate midiEventsToInstrument -- do it right or not at all.
Remove channel on midi.translate.getEndEvents
Use Python 3.11 error messages
Remove deprecated MeterSequence.flat -> for .flatten() Remove deprecated musicxml/testFiles.get(contentRequest) -- never used.
Add better docs to music21/prebase
make roman. _postFigureFromChordAndKey private as promised. Leave figureTuples as public.
remove RomanException -- just use RomanNumeralException
clean up docs for v3.11